Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local git tags interfere with versioning #125

Closed
mrvdb opened this issue Jun 20, 2019 · 2 comments
Closed

Local git tags interfere with versioning #125

mrvdb opened this issue Jun 20, 2019 · 2 comments

Comments

@mrvdb
Copy link
Collaborator

mrvdb commented Jun 20, 2019

The build system uses git describe --tags | cut -c 2- to construct a version number from tags like v0.9.1 to display something like 0.9.1-102-g31fa4b0

The --tags option makes it interfere with tags local to the repository which are just pointers and not annotated with a message like the version tags.

Options to resolve the issue:

  • omit --tags to only consider annotated tags, sufficient to resolve
  • use a pattern check like v* or something more fancy to filter tags
  • use --contains option? not sure how that would work

For now, just omitting --tags should be fine.

@mrvdb mrvdb changed the title Local tags interfere with versioning Local git tags interfere with versioning Jun 20, 2019
@mrvdb
Copy link
Collaborator Author

mrvdb commented Jun 27, 2019

any comments on this? I can make a PR, but the proposed change is fairly trivial

@thebaer
Copy link
Member

thebaer commented Jun 27, 2019

Yeah, removing --tags is a simple enough fix. Please feel free to make a PR, and we'll get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants