Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All posts display 'Invalid Date' #253

Closed
mrvdb opened this issue Jan 29, 2020 · 4 comments · Fixed by #254
Closed

All posts display 'Invalid Date' #253

mrvdb opened this issue Jan 29, 2020 · 4 comments · Fixed by #254
Labels
bug
Milestone
0.12

Comments

@mrvdb
Copy link
Collaborator

mrvdb commented Jan 29, 2020

I just pulled develop and now all posts will display an 'Invalid Date' just below the title

I'm guessing (but have not tested) this is related to the latest 'local date' munging I saw flying by.

The error occurs in static/js/localdate.js:

var d = new Date(dateEl.getAttribute("datetime"));

value of the attribute was: 2019-03-05 13:12:54 +0100 CET which indeed gives an Invalid date if passed into the js Date() constructor

Anything I missed?
@thebaer
Copy link
Member

thebaer commented Jan 29, 2020

Thanks for the report! Which browser is that in?

@mrvdb
Copy link
Collaborator Author

mrvdb commented Jan 29, 2020 •
edited

Firefox 72.0.2 arch linux

@thebaer thebaer added the bug label Jan 29, 2020
@thebaer thebaer added this to the 0.12 milestone Jan 29, 2020
thebaer added a commit that referenced this issue Jan 29, 2020
@thebaer
Fix date format in datetime attribute
50901d2 
Previously, the date format in this attribute for posts was invalid.
This caused local date rendering to fail in Firefox. This fixes that.

Closes #253
@thebaer thebaer mentioned this issue Jan 29, 2020
Merged
@thebaer
Copy link
Member

thebaer commented Jan 29, 2020

Got it, thanks! Confirmed the bug and just patched in #254. Will get that merged soon.

@mrvdb
Copy link
Collaborator Author

mrvdb commented Jan 29, 2020

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

Fix date format in datetime attribute writefreely/writefreely
2 participants
@mrvdb @thebaer