Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge inter-lines spaces on Chrome for android #290

Closed
Cl0v1s opened this issue Mar 30, 2020 · 3 comments
Closed

Huge inter-lines spaces on Chrome for android #290

Cl0v1s opened this issue Mar 30, 2020 · 3 comments

Comments

@Cl0v1s
Copy link

Cl0v1s commented Mar 30, 2020

Describe the bug

Originally brought on Mastodon
On some(?) version(s) of Chrome for Android, it appears that there is huge inter-lines spaces making the reading really hard.
Bug thumbnail

I would label this issue as "bug" since apparently, this only happens on some version of Chrome for Android.

Steps to reproduce (if necessary)

  1. On Chrome for Android (Chrome 80.0.3987.149 for Android)
  2. Go to https://write.as/kamen-reader/issue-10-hymenoptere-a-claques

Expected behavior

The interline space should be way smaller.
expected behavior

I played a bit with Chrome remote debug tools, and here is what I found:
The issue seems to be linked to these css lines:
#post article.norm { line-height: 1.5; }

Changing it for line-height: normal seems to correct the problem.
Correct

But to keep the relation between user font-size parameters, we can use em units for example line-height: 0.6em.
With em

After discussion, I would be happy to propose a MR :)

@Cl0v1s Cl0v1s changed the title Huge inter-lines space on Chrome for android Huge inter-lines spaces on Chrome for android Mar 30, 2020
@thebaer thebaer added the design label Mar 30, 2020
@thebaer
Copy link
Member

thebaer commented Mar 30, 2020

Thanks for opening an issue for this!

Before making any changes, I'd like to confirm that this affects more people, and that updating the line-height is the correct solution. To do that, we'll need to be able to replicate this -- I'm also running Chrome 80.0.3987.149 on Android but am unable to get the same results.

Can anyone else confirm they're seeing this issue?

@Cl0v1s
Copy link
Author

Cl0v1s commented Mar 30, 2020

If it can help, I'm running Android 7.0; Huawei VNS-L31

@thebaer
Copy link
Member

thebaer commented Sep 2, 2020

Closing this since we haven't heard about this issue from anyone else. Please feel free to reopen if anyone can replicate!

@thebaer thebaer closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants