Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links have rel="nofollow" #314

Closed
Crocmagnon opened this issue May 16, 2020 · 2 comments · Fixed by #482
Closed

Links have rel="nofollow" #314

Crocmagnon opened this issue May 16, 2020 · 2 comments · Fixed by #482

Comments

@Crocmagnon
Copy link

Crocmagnon commented May 16, 2020

Describe the bug

Links added by the user on an article or a pinned page have a rel="nofollow" attribute.

Steps to reproduce (if necessary)

Add a link in an article, either with markdown or HTML.
If the link is HTML and the user explicitly specifies another value for the rel attribute, this value is overridden when rendering the page.

Expected behavior

I see two issues with this:

  • This prevents Mastodon profile validation (which requires a rel="me")
  • This may reduce the visibility of the blogs since search engines apparently respect this directive

From the MDN:

Indicates that the linked document is not endorsed by the author of this one, for example if it has no control over it, if it is a bad example or if there is commercial relationship between the two (sold link).

IMHO this:

  • shouldn't be applied at all on internal links (links to href="#something" or to other pages of the blog)
  • should be applied by default on external links if the user doesn't specify anything else via a custom HTML anchor.

Application configuration

  • Single mode or Multi-user mode? single
  • Database? sqlite
  • Open registration? no
  • Federation enabled? yes

Version or last commit: 037fc40

@dimobelov
Copy link

Yes, just add Config option follow/nofollow and use it here https://github.com/writeas/writefreely/blob/9be05ef32e818e1be759fbca34533b9430b8d79e/postrender.go#L62

@thebaer
Copy link
Member

thebaer commented Jun 27, 2021

Thanks for bringing this up, @Crocmagnon. I just opened #482 to solve this. I think a no-brainer fix includes disabling rel="nofollow" for single-user blogs, so that's what I've done so far. But I'd love to know everyone's thoughts on other situations where we might also disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants