Navigation improvements #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to navigate between different blog sections: Customize, Stats, View.
This uses the main navigation bar for the Customize and Stats pages, instead of the collection-navigation bar used for multi-user / multi-collection instances.
|
Make sure the <NAV HTML elements are used to denote landmarks and otherwise. But this all looks good! I'm hoping accessibility is retained. I'm also hoping These HTML structural elements can be added, as well. |
|
Thanks for your input! This does put blog navigation into the more semantic Merging now! |
|
There is a little bit of excessive verbiage after navigating past the first banner landmark. The screen reader announces "Navigation landmark" 3 times. Perhaps wrapping all the top elements into one HTML NAV would be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some general quality-of-life improvements to blog navigation for multi- and single-user instances.
Persistent "New Post" button in the global navigation bar. Now it's easy to navigate back to the editor in a consistent way. Also, when on blog sub-sections like Customize and Stats, the button is contextual, i.e. clicking it will automatically select the current blog as the publishing target in the editor. Previously, this button was only enabled when an instance was configured with
chorus = true.Standard navigation across blog sub-sections. Now you can easily switch between customizing your blog, viewing stats, and viewing the blog itself with standard navigation. On single-user instances, these sections have been moved to the global navigation bar.
Single-user
Customize blog page
Multi-user
Customize blog page
Blogs page