Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date in Title #470

Closed
Tealk opened this issue Jun 22, 2021 · 1 comment · Fixed by #471
Closed

Date in Title #470

Tealk opened this issue Jun 22, 2021 · 1 comment · Fixed by #471
Assignees
@thebaer
Labels
bug
Milestone
0.13.1

Comments

@Tealk
Copy link

Tealk commented Jun 22, 2021

Describe the bug

If you enter a date in the title 12. april then it becomes 1. april
in the database it is correct
but if you write 12.april it works without problems

Steps to reproduce (if necessary)

Steps to reproduce the behavior:

  1. Create a new post
  2. enter a date in the title
  3. save the post

Expected behavior

the correct date should be displayed

Application configuration

  • Single mode or Multi-user mode? Multi-user mode
  • Database? mysql
  • Open registration? no
  • Federation enabled? yes

Version or last commit: 0.13.0
@thebaer thebaer added the bug label Jun 22, 2021
@thebaer
Copy link
Member

thebaer commented Jun 22, 2021

Good catch, @Tealk -- thanks for the report! I was able to verify this. I believe it's because we render the title as Markdown (to preserve title links), so we're parsing this as the first item in a list, instead of an arbitrary number followed by a dot. I'm looking into a fix now.

@thebaer thebaer added this to the 0.13.1 milestone Jun 22, 2021
@thebaer thebaer self-assigned this Jun 22, 2021
thebaer added a commit that referenced this issue Jun 22, 2021
@thebaer
Don't render title as list item
0ddca40 
This fixes an issue where "12. April" would get rendered as "1. April" because
it looks like a Markdown list item to our renderer. Now, we parse titles as
titles, instead of standalone text, which causes the renderer to give us the
results we want. This also adds some basic tests for the applyBasicMarkdown()
func.

Closes #470
@thebaer thebaer mentioned this issue Jun 22, 2021
Merged
@thebaer thebaer linked a pull request Jun 22, 2021 that will close this issue
Don't render title as list item #471
Merged
@thebaer thebaer closed this as completed Jun 23, 2021
@thebaer thebaer reopened this Jun 23, 2021
@thebaer thebaer closed this as completed Jun 29, 2021
@thebaer thebaer mentioned this issue Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thebaer thebaer

Labels
bug
Milestone
0.13.1
Development

Successfully merging a pull request may close this issue.

Don't render title as list item writefreely/writefreely
2 participants
@thebaer @Tealk