Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script #122

Merged
merged 5 commits into from Jun 15, 2019
Merged

Update script #122

merged 5 commits into from Jun 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 14, 2019

add a basic update script for admins to check for and upgrade to the latest version of writefreely


  • I have signed the CLA

Rob Loranger and others added 4 commits June 14, 2019 09:55
this bash script will download a new version, if any, and exrtact it to
a temporary location. Then copy the new files to the current directory
and restart the systemd service.
basic error check with descriptive output in update_server.sh
(or `writefreely -v` otherwise doesn't output anything)

Ref T555
And fix a typo

Ref T555
@thebaer
Copy link
Member

thebaer commented Jun 14, 2019

Thanks @robjloranger! I just made a few minor tweaks to the wording and error handling. Also, I noticed the "current version" output gets messed up when using a custom build, where the version might be something like 0.9.1-50-gac7d727

I don't think it's crucial to fix this right now for our purposes. But if it's quick to do, we should. What do you think, easy fix?

@thebaer thebaer added this to the 0.10 milestone Jun 14, 2019
@ghost
Copy link
Author

ghost commented Jun 15, 2019

Thanks @robjloranger! I just made a few minor tweaks to the wording and error handling. Also, I noticed the "current version" output gets messed up when using a custom build, where the version might be something like 0.9.1-50-gac7d727

I don't think it's crucial to fix this right now for our purposes. But if it's quick to do, we should. What do you think, easy fix?

That should be an easy fix.

store version output in new variable
slice output indexed from beginning instead of end. allowing for custom
build version numbers.

also fix weird spacing from tabs being two spaces wide, sorry :)
@ghost
Copy link
Author

ghost commented Jun 15, 2019

weird it still looks wrong, the spacing in the header

@ghost
Copy link
Author

ghost commented Jun 15, 2019

it looks fine in real life though
Screenshot from 2019-06-14 17-31-31

@thebaer
Copy link
Member

thebaer commented Jun 15, 2019

Awesome, thanks! Spacing looks good :)

@thebaer thebaer merged commit 2b8b522 into develop Jun 15, 2019
@thebaer thebaer deleted the update-script branch June 15, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant