Private instances #123
Merged
Private instances #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of all changes needed to support entirely private instances, where all blogs are only visible to other authenticated users on an instance (ref T576). It begins by changing how Handler methods check an endpoint's permissions. - Renames UserLevelLEVEL consts to UserLevelLEVELType - Adds UserLevelLEVEL funcs with same names as previous consts. Each returns a UserLevel - Adds a new UserLevelReader that restricts access based on app configuration. This is now used on collections and posts. - Changes routing a bit so static files are always accessible
This verifies that a user is authenticated before getting to the actual handler on API endpoints where a user is reading content. Ref T576
(on private instances) Ref T576
(for private instances) Ref T576
Previously, that func was duplicated here.
ghost
reviewed
Jul 1, 2019
thebaer
commented
Jul 1, 2019
Previously, we just included the value of `ul`, which is a func. This now calls `ul()` and logs that value.
|
testing looks good running locally. I haven't tested federation though, did you want me to do that too? |
ghost
approved these changes
Jul 1, 2019
|
Thanks @robjloranger -- no need to test federation. Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
privateconfig setting to make an instance entirely private. That is, when enabled, blogs will only be readable by other authenticated users on the same instance.It still needs a bit of testing, so it's a draft for now.
When finished, this closes T576.