Automatic certificates from Let's Encrypt #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new config option in the `[server]` section: `autocert`. When true, WF will automatically generate certificates instead of using ones from the provided cert path. However, all generated certificates will be stored in the configured `tls_cert_path`. Ref T542
Previously, this would pass in the instance's full (and invalid) URL. Now it passes only the host name. Ref T542
This fixes certificate validation, while keeping HTTP -> HTTPS redirection. Ref T542
This adds a new "Secure (port 443), auto certificate" option to the "Web server mode" prompt when running `writefreely --config`. When chosen, it'll set `autocert` to `true` and set the path for certs and keys to `certs`. Ref T542
|
This still needs documentation. |
|
Ideally we'll also explain how to do this in some kind of "setup" guide. But the basic docs are there, so merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables admins to run WriteFreely as a standalone server that automatically generates certificates, powered by Let's Encrypt (T542).
It adds a new config option under the
[server]section:autocert. When set totrue(and with non-emptytls_cert_pathandtls_key_pathvalues, plusport = 443), WriteFreely will serve the instance on port 443 and automatically generate a certificate for the configured host.This also adds a new option during the interactive config process that allows the user to choose automatic certificate generation, in addition to the previous option of manually configuring the certificate location.