Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style collection 404 page like rest of blog #143

Merged
merged 3 commits into from Aug 7, 2019
Merged

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Jul 21, 2019

This displays the "page is missing" text within the same page as any other blog post, keeping customizations, pinned pages, and general blog navigation.

T493

This displays the "page is missing" text within the same page as any
other blog post, keeping customizations, pinned pages, and general blog
navigation.

Ref T493
@thebaer thebaer added this to the 0.11 milestone Jul 21, 2019
@thebaer
Copy link
Member Author

thebaer commented Jul 21, 2019

Still TODO:

  • Return better responses for different requested Content-Types
  • Show a similar page when there are no posts with a given tag (probably out of scope for this specific task)

@thebaer
Copy link
Member Author

thebaer commented Aug 7, 2019

The first item is fixed now, and the second is now tracked in T682.

@thebaer thebaer merged commit b06d1c2 into develop Aug 7, 2019
@thebaer thebaer deleted the collection-404 branch August 7, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant