Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tar bombs #164

Merged
merged 4 commits into from Aug 22, 2019
Merged

fix tar bombs #164

merged 4 commits into from Aug 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2019

this changes the release targets in the Makefile to use a subdirectory
of the format BINARYNAME_GITREV so extracting the archive results in a
single directory.


  • I have signed the CLA

closes #160

this changes the release targets in the Makefile to use a subdirectory
of the format BINARYNAME_GITREV so extracting the archive results in a
single directory.
@thebaer
Copy link
Member

thebaer commented Aug 12, 2019

What do you think if we name the directory writefreely instead of including the version info? That should make installation / upgrading easier by maintaining existing paths, e.g.:

tar -C /var/www -xzf writefreely_0.10.0_linux_amd64.tar.gz

would always produce /var/www/writefreely.

@joyeusenoelle
Copy link
Contributor

The only problem I can think of is a rare edge case where someone wants multiple versions installed, but they can do that manually so I'm not sure we need to care about it.

@ghost
Copy link
Author

ghost commented Aug 12, 2019

sure, sounds good to me

@thebaer
Copy link
Member

thebaer commented Aug 22, 2019

That fixes it! Looks good -- thanks @robjloranger.

@thebaer thebaer merged commit 4d97856 into develop Aug 22, 2019
@thebaer thebaer deleted the tar-bombs branch August 22, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tar is bombing the cwd with files
2 participants