New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for lessc executable in any location #165
Conversation
previously the checks were explicit locations which does not work when using something like nvm to manage node packages and versions. this checks for the executable and sets the script variable LESSC to the full path of the one found. if none was found the make command will error.
When running
So I changed the file a bit, and that seemed to fix it. Let me know if it messes anything up when you try it. |
works for me still as well 👍 |
Great, and just to confirm, it works when |
hmm, no it doesn't seem to detect the binary is missing. |
this one is weird, I guess the variable is never undefined but not always what we want? |
Hmm, yeah... Maybe an empty check instead would do it? |
white space was throwing me around, double check this one for me |
It seems to be catching it, but now |
weird, what is the error? it works .. on my machine 🤣 |
Heh 😄 Error is:
Instead, |
oooh, |
Great, now let's just make sure all the stylesheets are still generated :) |
accidentally removed two lines from make all fix check when trying to install lessc
this is a mess, I fix one issue and the other reappears. Maybe we need to use some bash instead. |
ok, ready for another test @thebaer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍 Just tweaked the error message a bit. Good to go!
previously the checks were explicit locations which does not work when
using something like nvm to manage node packages and versions.
this checks for the executable and sets the script variable LESSC to the
full path of the one found.
if none was found the make command will error.