Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing collection hostname #171

Merged
merged 1 commit into from Sep 9, 2019
Merged

fix missing collection hostname #171

merged 1 commit into from Sep 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2019

GetCollections and GetPublishableCollections now take a hostname
parameter to allow setting the collecion hostname.

All collections used in memory now have their hostname set.


GetCollections and GetPublishableCollections now take a hostname
parameter to allow setting the collecion hostname.

All collections used in memory now have their hostname set.
@ghost
Copy link
Author

ghost commented Aug 12, 2019

This does seem like a lot of extra work compared to storing the hostname in the collection. The post could then get it's hostname from it's associated collection and we wouldn't be passing it around.

Then for things like export, we could omit the hostname value to avoid issues moving blogs across deployments.

But that is for another day, this fixes the mentioned issue.

@thebaer thebaer added this to the 0.11 milestone Sep 4, 2019
@thebaer
Copy link
Member

thebaer commented Sep 9, 2019

Yeah, I'm just not excited about adding a variable to the Collection struct that isn't going to change between different Collections. This seems like the least-worst way to do things, at least.

But looks good, thanks!

@thebaer thebaer merged commit 94b8fa7 into develop Sep 9, 2019
@thebaer thebaer deleted the empty-coll-host branch September 9, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Collection.hostName is empty in the logs
1 participant