Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathjax in binaries #181

Merged
merged 5 commits into from Aug 11, 2020
Merged

Mathjax in binaries #181

merged 5 commits into from Aug 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2019

removes the submodule for mathjax and instead includes a copy of the script

ref #176, will need a tag and new release to close


  • I have signed the CLA

Rob Loranger added 2 commits September 11, 2019 10:57
this includes a copy of mathjax@3.0.0/es5/tex-mml-chtml.js
@ghost ghost requested a review from thebaer September 11, 2019 18:26
@thebaer
Copy link
Member

thebaer commented Sep 11, 2019

I think we also need the fonts and images from the library, right?

@ghost
Copy link
Author

ghost commented Sep 11, 2019

I'm not certain, the docs just say to link the one script.

I did notice that the body is not being parsed properly though so I will need to see what's going on here.

@ghost
Copy link
Author

ghost commented Sep 11, 2019

this uses the svg version which does not require any external fonts
Screenshot from 2019-09-11 14-17-28

@ghost
Copy link
Author

ghost commented Sep 12, 2019

something is weird again, this was working when I took that shot but now it's not 🤔

Rob Loranger added 2 commits September 12, 2019 10:12
with only the single script, there were still many requests to a CDN.
this fixes that and speed up the page load a bit as well.
@ghost
Copy link
Author

ghost commented Sep 12, 2019

I didn't want to but it seems the best solution. I added the full build of mathjax components and assets to avoid unwanted requests to CDNs.

Firefox was/is just being weird and caching things, even with cache disabled.. other browsers are working as expected only using local files. tested with [chrome, chromium, opera, brave, midori]

@thebaer
Copy link
Member

thebaer commented Feb 5, 2020

I'm not sure how to verify this since I'm not really a user of this feature. If anyone in the community can try it out and weigh in on whether or not it works, please do!

@ghost
Copy link
Author

ghost commented Feb 11, 2020

Hey @thebaer, to verify this is working you can try somewhere like http://atomurl.net/math/ and use a sample from the selection. This will give you the markup and a preview of it rendered to compare to.

@thebaer
Copy link
Member

thebaer commented Aug 11, 2020

Worked for me! Merging now.

@thebaer thebaer added this to the 0.13 milestone Aug 11, 2020
@thebaer thebaer merged commit 5f52c23 into develop Aug 11, 2020
@thebaer thebaer deleted the mathjax-in-binaries branch August 11, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant