add user invite instructions #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a new page with instructions for sharing user invites if a user clicks the link for one of their own invite codes they are directed to a page with clear instructions for it's use. if a user clicks another users link they are redirectec to their account settings witha flash telling them they do not need to register.
|
let me know if |
ghost
requested a review
from 
This ensures we see a 404 page when looking up an invalid invite URL, even if the user is logged in. Ref T690
Ref T690
This uses the Invite fetched from the database to explain a bit more about how the invite URL expires. It also reduces some space around the input box. Ref T690
font-size-adjust is still a flag-enabled feature in Chrome 77, and doesn't have widespread support across browsers. So instead this uses font-size to make the text large enough. Ref T690
Ref T690
thebaer
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Looks good!
I made some changes to the copy and added a bit more explanation about the expiration of links, after seeing the page in action.
I still think it'd be fine to send users to / (root path), or even the normal user invite page, if they navigate to another user's invite link. But it's enough of an edge case -- we can always revisit later. Thanks for the work on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a new page with instructions for sharing user invites
if a user clicks the link for one of their own invite codes they are
directed to a page with clear instructions for it's use.
if a user clicks another users link they are redirectec to their account
settings witha flash telling them they do not need to register.
ref T690