Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update IsJSON to check for Accept header #185

Merged
merged 1 commit into from Nov 7, 2019
Merged

update IsJSON to check for Accept header #185

merged 1 commit into from Nov 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2019

this changes the helper IsJSON to take a request instead of a string,
allowing to check multiple headers. In this case both Content-Type and
Accept.


  • I have signed the CLA

closes #178

this changes the helper IsJSON to take a request instead of a string,
allowing to check multiple headers. In this case both Content-Type and
Accept.
@ghost ghost requested a review from thebaer September 18, 2019 19:45
@thebaer thebaer added this to the 0.11 milestone Oct 10, 2019
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@thebaer thebaer merged commit fea62b1 into develop Nov 7, 2019
@thebaer thebaer deleted the accept-json branch November 7, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve a Collection API endpoint uses request content-type instead of accept header
1 participant