add dates to posts on collections w/ blog format #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2019 13:20
the old class was dt-published, at first it was split to keep the display: block without the rest. this changes the published class to subtle to be more logical
|
I changed the chorus template as well, quick to revert if you prefer. I thought it would be good to be consistent |
thebaer
requested changes
Oct 2, 2019
There was a problem hiding this comment.
Still need to review more, but just a few quick notes after skimming the code:
- we should switch back to
dt-publishedas the class name, as it's a microformats property - let's extract the shared CSS between templates into
less/core.less
also changes less function article-title to have a bottom margin of 0.5em as it was being reset on both post views. this also brings anonymous posts into a consistent style with the rest.
ghost
mentioned this pull request
|
Thanks for giving this a shot, but a lot of the layout got messed up here, and it looks like it changes the previous header spacing we had (which ideally we'd avoid). So I took another stab at this in #235. If that works, we'll merge that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds conditional date placement on collection posts using the 'blog' format.
When dates are shown without a post title, the date is formatted as the body text with top placement.
ref T669