show timestamps in local date/locale #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a helper script to rewrite all time elements with a proper datetime attribute into the users locale via the browser navigator.language. collection, collection-post and chorus-collection-post templates now include this script
|
Let's also get this code on the |
|
Thanks 👍 Is this PR ready to go or still a draft? |
ghost
marked this pull request as ready for review
|
It's good, #190 will just need the script included after. |
Posts without an explicit title render the date as the post header in lists of posts (like on the blog index and tag pages). This updates localdate.js to properly adjust those dates, too.
|
Also needed to handle cases where posts don't have a title (so the date becomes the clickable title on blog index, tag page). Previously, the script would overwrite the link so you couldn't navigate to the post itself on those pages. All fixed and good to go! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a helper script to rewrite all time elements with a proper
datetime attribute into the users locale via the browser
navigator.language.
collection, collection-post and chorus-collection-post templates now
include this script
requires #190, might need a rebase
ref T670