New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix password-protected page template #222
Conversation
Fixed "user-supsended" to "user-suspended"
Use "silenced" phrasing instead of "suspended"
Previously, any password-protected collection on a suspended account would prompt visitors for a password, and *then* take them to the "not found" page. This fixes that.
Also noticed an issue with password-protected blogs for suspended accounts not returning a 404 right away. Fixed that in 6f6204a. This is ready for review now. |
Logged-in users never see this particular page, so it's not needed here.
everything is working as described except another issue: If the user with the protected blog is silenced, and another user who has entered the password visits the page of a post, not the blog root, the post is still displayed but with the 'you are silenced' banner. I tested out a small fix to check for suspended collection owners on protected collection posts:
I can push that up if you like. |
Good catch. Yeah, feel free to push that -- though maybe combine the logic? e.g.
|
a user who had previously authenticated on a protected collection would still see the post after the owner was silenced, with a banner meant for the owner displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with fix for previous authorized users this is good now.
tested logged in user, owner and logged out users for both protected collection and protected collection post with and without the owner silenced
Great, confirmed this is working. Merging now, thanks! |
A typo in the
password-protected.tmpl
template would previously cause the page to fail. This fixes that.It also updates the "silenced" alert text in
edit-meta.tmpl
.Resolves #221.