Pass OAuth requests through OAuth handler #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us our standard logging and passes around errors with impart.HTTPError. Ref T705
ngerakines
approved these changes
Jan 2, 2020
|
Looks great! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us consistent logging on OAuth endpoints and passes around errors with
impart.HTTPError, as we do elsewhere -- while keeping the current JSON schema for OAuth requests ({"error": "..."}).@ngerakines curious about your thoughts on this -- whether it works or if it might cause issues down the road, e.g. with error handling for various request types.
Part of T705.