Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth registration improvements #232

Merged
merged 10 commits into from Jan 8, 2020
Merged

OAuth registration improvements #232

merged 10 commits into from Jan 8, 2020

Conversation

ngerakines
Copy link
Collaborator

This PR improves the account creation flow through OAuth providers. Instead of immediately creating a user, a populated form is presented with suggested values. Some basic error handling is implemented.

Added

  • The /oauth/signup handler, template, and route.
  • The server.hash_seed configuration variable used to verify the integrity of oauth variables used in account creation.

Changed

  • The account creation behavior used when a user account should be created as a result of the oauth flow.
  • I have signed the CLA

@ngerakines ngerakines self-assigned this Jan 3, 2020
@ngerakines ngerakines marked this pull request as ready for review January 3, 2020 19:39
@ngerakines ngerakines changed the title T712 oauth registration improvements OAuth registration improvements Jan 3, 2020
thebaer
thebaer requested changes Jan 4, 2020
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Just have some feedback on validation and the signup form.

I'm going to play around with the design of the login page, making the buttons graphical and testing out different layouts.

oauth_signup.go Outdated Show resolved Hide resolved
oauth_signup.go Outdated Show resolved Hide resolved
oauth_signup.go Outdated Show resolved Hide resolved
oauth_signup.go Outdated Show resolved Hide resolved
pages/signup-oauth.tmpl Outdated Show resolved Hide resolved
thebaer
thebaer reviewed Jan 7, 2020
View reviewed changes
oauth.go Outdated Show resolved Hide resolved
thebaer
thebaer reviewed Jan 7, 2020
View reviewed changes
oauth.go Outdated Show resolved Hide resolved
thebaer
thebaer approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! Thanks, merging now.

@thebaer thebaer merged commit a2a9f60 into develop Jan 8, 2020
@thebaer thebaer deleted the T712-oauth-registration-improvements branch January 8, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer thebaer approved these changes

Assignees

@ngerakines ngerakines

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ngerakines @thebaer