Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename base_url to collection_url in Markdown API #233

Merged
merged 1 commit into from Jan 5, 2020
Merged

Rename base_url to collection_url in Markdown API #233

merged 1 commit into from Jan 5, 2020

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Jan 5, 2020

This renames the base_url parameter to collection_url, to make it clear what the parameter is for (i.e. not the base URL of the instance, but of the collection itself).

Part of T519

@thebaer thebaer added this to the 0.12 milestone Jan 5, 2020
@thebaer thebaer requested a review from a user January 5, 2020 16:25
ghost
ghost approved these changes Jan 5, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I didn't test but I don't think that string needed to be initialized so should be good.

@thebaer
Copy link
Member Author

thebaer commented Jan 5, 2020

Cool, thanks for looking at it 👍

@thebaer thebaer merged commit 9be5340 into develop Jan 5, 2020
@thebaer thebaer deleted the markdown-api-rename branch January 5, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thebaer