Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth alias field not set correctly #238

Merged
merged 1 commit into from Jan 14, 2020
Merged

OAuth alias field not set correctly #238

merged 1 commit into from Jan 14, 2020

Conversation

ngerakines
Copy link
Collaborator

This PR resolves a bug where the alias field used during oauth registration was not correctly set for the write.as oauth provider.

  • I have signed the CLA

@ngerakines ngerakines added the bug label Jan 14, 2020
@ngerakines ngerakines self-assigned this Jan 14, 2020
thebaer
thebaer approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works! Merging now.

@thebaer thebaer added this to the 0.12 milestone Jan 14, 2020
@thebaer thebaer merged commit c7b7979 into develop Jan 14, 2020
@thebaer thebaer deleted the oauth-bugfix-alias-signature branch January 14, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer thebaer approved these changes

Assignees

@ngerakines ngerakines

Labels
bug
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ngerakines @thebaer