Switch to a maintained fork of XGO #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @techknowlogick, thank you for contributing this! We'd be happy to accept it. Everything looks good, though running it modifies |
|
@thebaer just added the modifications to go modules, please let me know if I can make any other changes :) |
|
Looks great, thanks! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hey, I'm one of the project leads for Gitea, and we also use XGO to cross compile our binaries, however we have forked xgo to ensure that versions are kept up to date and have added other enhancements.
I've also added arm-6 as a compile target, this is due to its wider support on arm based devices (arm6 works on arm7 devices, but not the reverse).
Note: Due to switching from Ubuntu 14.04 to 18.04 as a base image in the fork this prevents binaries from working on Linux Kernel versions below 3.1. However due to Ubuntu 14.04 being past EOL, and also that Linux Kernel version being of a certain age Gitea proceeded with that being acceptable (it may not be acceptable for you).
I understand that this is an unsolicited PR, and it changes an upstream dependency, as such please feel free to close it if it doesn't align with your project.