OAuth account management #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd required data migration. T713
thebaer
reviewed
Jan 16, 2020
|
I went ahead and updated the schema and logic around that column so it's a
Ideally, we could show an error in this case or some other kind indication to the user, as this is a little confusing. |
… a user that already has the slack account attached. Added GitLab to settings page as oauth option.
This includes the chosen GitLab display name in the button text.
- Break up linked / to-link sections - Add logos for all services - Lay out buttons horizontally - Tweak the copy Ref T713
|
Looks great! Verified the issue is fixed. I tweaked the design and wording on the Account Settings page (see below), and made a few other changes. Now I'm just verifying different configurations and edge cases. If that looks good, I'll merge. No accounts linked
Slack linked
|
|
Merging now! Thanks @ngerakines! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces oauth account management functionality on the account settings page. With it, oauth accounts can be added and removed from existing accounts.