OAuth signup form tweaks #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All usernames should be lowercase, so this generates any username suffix (in cases of collision) with only lowercase letters. It also removes vowels to prevent bad 5-letter words from forming. Ref T712
This checks the user's inputted username as they type it, and prevents form submission if the name is taken. Ref T712
Having a `Username` field populated in the page data tells the base template to display navigation that only a logged in user should see. So this renames the field to `LoginUsername`, similar to our login.tmpl page. Ref T712
"alias" is the name of a different collection field, so this renames the variable internally to make things clearer.
This uses the given username as the Display Name / Collection Title if a user doesn't give one -- as might happen when authenticating with Write.as. Ref T712
This makes it possible to complete OAuth signup without creating a password on the WriteFreely instance. A user can then add a password to their account through their Account Settings page without any admin action (all of this logic is already in place). Ref T715 T712
This removes a bit of friction. Ref T715 T712
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes / adds a few things during OAuth signup (see commits for more notes):
Including changes designed to reduce friction during the signup process: