Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the gorilla/session library to v1.2.0, which gets rid of the gorilla/context dependency, which might have been causing a memory leak.
We noticed some serious memory leakage on Write.as that seemed to point to this library. One heap snapshot:
Then with the help of the following articles, we tracked it down to this dependency. We upgraded the necessary library, which seems to have completely fixed the issue so far:
We'll give this a little more time to verify there isn't anything else causing a leak. But combined with #249, this should fix #133.