Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Novel pagination #272

Merged
merged 4 commits into from Mar 27, 2020
Merged

Fix Novel pagination #272

merged 4 commits into from Mar 27, 2020

Conversation

cjeller1592
Copy link
Contributor

@cjeller1592 cjeller1592 commented Feb 28, 2020

Before, last page of blogs set to "Novel" would show "Newer" link at bottom of page instead of "Previous." PR fixes this and now shows "Previous."

  • I have signed the CLA

Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested on a Novel format blog, on the last page the "Previous" link showed up on the right side, instead of the left, as it is on previous blog pages. Just need to make the following changes to fix that logic and clean things up.

templates/collection.tmpl Outdated Show resolved Hide resolved
templates/collection.tmpl Outdated Show resolved Hide resolved
templates/chorus-collection.tmpl Outdated Show resolved Hide resolved
@thebaer thebaer added this to the 0.12 milestone Mar 27, 2020
@thebaer
Copy link
Member

thebaer commented Mar 27, 2020

Looks great! Thanks for fixing this @cjeller1592, and congrats on your first code contribution to WriteFreely! 🎉

@thebaer thebaer merged commit 8ad04c5 into develop Mar 27, 2020
@thebaer thebaer deleted the novelfix branch March 27, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants