Clean up ActivityPub mentions #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we might potentially return a nil activitystreams.Object, which would crash the app. This fixes that.
This ensures handles are always stored without leading @ symbol.
This fixes log formatting and makes verbiage consistent & concise.
This makes the app less error-prone by avoiding a regexp.MustCompile() call in the ActivityObject() method, saves CPU work, and reuses code.
This alters the V6 migration to make the column NULLable. Anyone who has already run this migration will need to manually update their database.
|
This is ready for review now. Changes are currently live on Write.as. |
|
For anyone running their instance from the Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some light cleanup around ActivityPub mentions (#195 / T627), from stability to schema design and logging improvements.