core.less: Use a bigger font size for h2 #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The font-size for h2 was set to be 1.17em, which is also the font size defined for h3 by user agent stylesheet. This lead to both h2 and h3 being rendered in same size. Use 1.2em for h2. Closes: writefreely#217
|
Thanks for contributing this, @RJ722! I'll test and verify this fix soon. Otherwise, anyone else should feel free to weigh in! |
thebaer
requested changes
Jul 23, 2020
There was a problem hiding this comment.
I think we should actually go with 1.4em, to make it consistent with the h2 font size from the blog home page: https://github.com/writeas/writefreely/blob/53cb5c3837796eb72b0af8a317006db7419ef678/less/core.less#L659-L664
|
Making these revisions in #368. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font-size for h2 was set to be 1.17em, which is also the font size defined for h3 by user agent stylesheet. This lead to both h2 and h3 being rendered in same size. Use 1.2em for h2.
Closes: #217