New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login with generic oauth feature++ #317
Conversation
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Add generic Oauth allow_logout option
Thanks for taking over development on this, @pascoual! I'll review this soon. |
Apologies for dropping out on this one - got extremely busy elsewhere. @pascoual thank you for jumping in here, and I'm sorry you were unable to reach me. I'll try to keep an eye on this PR - if you need anything mention me and I'll try to jump in 😄 |
I need to add an option : disable_password_auth as we want to use WF with the SSO only. |
This would be awesome, since it's exactly what I was trying to do. Thanks 😁 |
Look at the last commit, it's done ;) ! |
@pascoual that’s super awesome! thank you for taking over from me - this is not my coding language haha i can’t wait to try it out |
This would enable to use WriteFreely on multiuser instances of YuNoHost, using one other app as oauth provider, like Nextcloud, without the need to implement LDAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience on my review. This looks great! Just one issue with the logic on the landing page, and then we'll need to resolve the conflicts introduced after merging #293.
Got it, will fix it asap. |
I've also fix some merging issues from previous commit and find running WF in dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pascoual! Looks great -- merging now.
Create from @ketudb PR with @thebaer requested modifications about Connect / Disconnect buttons from Account Settings page
This aims to add a configurable, generic OAuth client module, so that it can be used with things like Keycloak etc, without needing a separate OAuth client configuration for every provider.
It adds the following ini settings under
oauth.generic
:I've try to contact @ketudb but without success.