Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with generic oauth feature++ #317

Merged
merged 17 commits into from Aug 17, 2020

Conversation

pascoual
Copy link
Contributor

@pascoual pascoual commented Jun 6, 2020

Create from @ketudb PR with @thebaer requested modifications about Connect / Disconnect buttons from Account Settings page

This aims to add a configurable, generic OAuth client module, so that it can be used with things like Keycloak etc, without needing a separate OAuth client configuration for every provider.

It adds the following ini settings under oauth.generic:

* `client_id`, `client_secret`, `CallbackProxy`, `CallbackProxyAPI` as usual

* `host`: The hostname/base URL for the oauth server

* `display_name`: The display name (defaults to "OAuth")

* `token_endpoint`, `inspect_endpoint`, `auth_endpoint` which will all be different depending on the oauth implementation.

* `allow_disconnect`: allow the user to disconnect his writefreely account from `oauth.generic` one

I've try to contact @ketudb but without success.

echoesactiii and others added 14 commits May 30, 2020 23:58
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Add generic Oauth allow_logout option
@thebaer
Copy link
Member

thebaer commented Jun 8, 2020

Thanks for taking over development on this, @pascoual! I'll review this soon.

@thebaer thebaer added this to the 0.13 milestone Jun 8, 2020
@echoesactiii
Copy link
Contributor

Apologies for dropping out on this one - got extremely busy elsewhere. @pascoual thank you for jumping in here, and I'm sorry you were unable to reach me. I'll try to keep an eye on this PR - if you need anything mention me and I'll try to jump in 😄

@pascoual
Copy link
Contributor Author

I need to add an option : disable_password_auth as we want to use WF with the SSO only.
@thebaer: I will make few more commits

@echoesactiii
Copy link
Contributor

I need to add an option : disable_password_auth as we want to use WF with the SSO only.
@thebaer: I will make few more commits

This would be awesome, since it's exactly what I was trying to do. Thanks 😁

@pascoual
Copy link
Contributor Author

Look at the last commit, it's done ;) !

@echoesactiii
Copy link
Contributor

@pascoual that’s super awesome! thank you for taking over from me - this is not my coding language haha

i can’t wait to try it out

@c-cesar
Copy link

c-cesar commented Jul 26, 2020

This would enable to use WriteFreely on multiuser instances of YuNoHost, using one other app as oauth provider, like Nextcloud, without the need to implement LDAP.
And this is my current usercase.
Tank you so much.

@thebaer thebaer mentioned this pull request Aug 12, 2020
1 task
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on my review. This looks great! Just one issue with the logic on the landing page, and then we'll need to resolve the conflicts introduced after merging #293.

pages/landing.tmpl Outdated Show resolved Hide resolved
@pascoual
Copy link
Contributor Author

Got it, will fix it asap.

@pascoual pascoual requested a review from thebaer August 16, 2020 18:43
@pascoual
Copy link
Contributor Author

I've also fix some merging issues from previous commit and find running WF in dev.

Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pascoual! Looks great -- merging now.

@thebaer thebaer merged commit dfa14c9 into writefreely:develop Aug 17, 2020
@thebaer thebaer mentioned this pull request Aug 19, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants