preload fonts.css in base.tmpl #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, this is an "explorational" pull request.
PageSpeed Insights tells me I could gain about 500ms on my blog, if I preloaded fonts.css.
Would you be open to preloading fonts like this?
From a read of the templates and the generated HTML, it seems you always end up at the resource at `{{.Host}}/css/fonts.css`. The JS bit in the bottom just controls when to enable it. Preloading with a `<link>` element shouldn't change that behavior.
Let me know if that looks acceptable, I'm happy to throw additional commits in this pull request branch for the other template files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is an "explorational" pull request.
PageSpeed Insights tells me I could gain about 500ms on my blog, if I preloaded fonts.css.
Would you be open to preloading fonts like this?
From a read of the templates and the generated HTML, it seems you always end up at the resource at
{{.Host}}/css/fonts.css. The JS bit in the bottom just controls when to enable it. Preloading with a<link>element shouldn't change that behavior.Let me know if that looks acceptable, I'm happy to throw additional commits in this pull request branch for the other template files.
[Describe the pull request here...]