Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft list paging #356

Merged
merged 5 commits into from May 4, 2021
Merged

Draft list paging #356

merged 5 commits into from May 4, 2021

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Jul 30, 2020

This loads 10 posts at a time on a user's Drafts page, and includes a "Load more" button at the bottom to dynamically load more entries (T401, T696)

It also modifies the GET /api/me/posts endpoint to accept the following parameters:

  • anonymous=1 - returns only anonymous / draft posts
  • page={number}- returns posts for the given page {number}. If 0, all posts are returned.

  • I have signed the CLA

This adds a "load more" button to the bottom of the draft posts page,
which calls /api/me/posts with new parameters and the current page
number. It then populates the page accordingly.

Ref T696 - load anon. posts with ?anonymous=1&page=1
Ref T401 - completes UI for post loading
@thebaer thebaer added this to the 0.13 milestone Jul 30, 2020
@thebaer
Copy link
Member Author

thebaer commented Jul 30, 2020

Last issue to fix:

  • Loaded posts don't include the "Move to..." action

@thebaer thebaer marked this pull request as ready for review April 7, 2021 20:44
@thebaer
Copy link
Member Author

thebaer commented Apr 28, 2021

There was one last issue: paged posts wouldn't show an extracted title when there was no explicit title on them. This is now fixed.

@thebaer
Copy link
Member Author

thebaer commented May 4, 2021

Merging now!

@thebaer thebaer merged commit 73450a5 into develop May 4, 2021
@thebaer thebaer deleted the draft-list-paging branch May 4, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant