New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WYSIWYG editor option #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps it consistent with all our other CSS.
- Match light / dark theme - Make editor fill the viewport - Remove borders - Add spacing in toolbar
This takes styling from the Classic Editor on Write.as. It adds all application code for auto-saving the title, publishing it with the post body, and including it in the word count.
This upgrades @babel/preset-env to 7.9.0 from 7.8.7. See: nodejs/node#32852 (comment)
…publish keyboard shortcut, readmore node
@VV-EE I'm running the following commands after these updates:
And getting this output in the browser's console now:
Is there anything I'm missing? |
When I comment out this line that seems to be causing the issue, I get another error:
|
This uses String.replace() instead of String.replaceAll().
Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft pull request adds a new editor option: a what you see is what you get editor, powered by ProseMirror.
To test this out, set
editor = wysiwyg
in your configuration file.TODO
<!--more-->
) and other shortcodes (ideally through a menu item)Thanks to @robjloranger for getting this work started! When complete, this will close T727.