New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile/docker-compose fixes #407
Conversation
Updates versions and uses maria DB instead of sqlite in the docker-compose. Also fixes things related to networks, generating config, etc.
Any review on this? Happy to modify it as necessary |
Thanks for submitting this, @conor-f! It would be great to get these Docker issues fixed. I won't be able to help much since this isn't my area of expertise, but maybe @shleeable or @kaiyou could review? |
I just ran into the same issue. Changes look good to me. |
Though I would make one suggestion, wouldn't it be easier to have a simple sqlite example instead of spinning up a mariadb image too? |
Thanks for taking a look, @finn-ball! Just to be sure @conor-f, which issues in particular should be completely closed when we merge this? |
I would close the two issues and one PR I linked in the original comment. There are improvements that could be made to this, but this PR will allow people to just pull the |
Perfect, that'll work! Merging this now. |
@conor-f: please update the pr to do a
It should work with 644, that should be enough for the writefreely process to access. |
I recently tried to install writefreely using my docker-compose setup that I use for managing all self hosted services I'm running. It took a lot of work to get the docker-compose setup working for writefreely but this PR should make things significantly easier.
This is the workflow of this PR to install writefreely with docker-compose:
docker-compose.yml
that is modified in this PR, and put it in a directory.I know this is kind of messy still but this is working now so let me know any changes you'd like to see to get this merged. This should (mostly) solve #139 #323 and #357