Add pagination to tag subpages #438
Conversation
Mostly copied the logic for pagination from non tag collection
* Implements PrevPageURL and NextPageURL * This allows the collection-tag template to get proper urls for paginating using tags.
There was a problem hiding this comment.
Thanks for submitting this fix! Sorry it's taken so long to review this.
It looks like this does add most of what we need for pagination, but it also always shows the "Older" link on tag pages, even when there aren't more pages to go to. We'll need to fix that before merging.
Ah gotcha missed that. Will fix soon |
|
Hey @Dak425, any update on this? |
|
Sorry I have not had time to, someone else can finish it up if they
would like to
…On Mon, Sep 13, 2021, 6:43 PM Matt Baer ***@***.***> wrote:
Hey @Dak425 <https://github.com/Dak425>, any update on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#438 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWQNHNUMXSS4W4I7OBEVX3UBZ5APANCNFSM4YFYB6MQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Patched this up, but only tested with MySQL and multi-user instance. Need to confirm it works with SQLite and single-user blogs, then we can merge. |
|
Looks good! Merging now. |
Add pagination to tag subpages
Fixes #362