New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix following from Mastodon with Authorized Fetch enabled #439
Conversation
This fixes federation with Mastodon instances that have Authorized Fetch turned on by signing the GET request to fetch the actor when a blog is first followed. Ref T820
This skips the silenced-user check. Ref T820
This skips the silenced-user check. Ref T820
There were a few missing pieces, but this is ready for review now 👍 |
I just attempted to follow this blog: https://write.as/skepticaldruid from https://traingletoot.party, and I got the same result as before: it requests to follow, but the follow never actually goes through. I am not sure if Authorized Fetch is turned on, but I am on Mastodon v3.3.0, and it’s all managed through https://masto.host. I’ve been looking forward to this fix, so let me know if I can help with any additional troubleshooting! |
Thanks for offering to help, @amwelles! Yeah, I think I'm seeing the same issue with following Write.as blogs from our Mastodon instance, https://writing.exchange (also managed through Masto.host). However, everything seems to work on our other (more seldom-used) Mastodon instance, https://m.abunchtell.com. Very strange. I'm going to do a little more digging, and will let you know if I could use help on anything! |
FWIW, same issue from mastodon.art. Can help test too. |
Seem to have narrowed it down after noticing this issue. Can you try these steps, to see if it fixes things?
|
Step 4: the switch to "Unfollow" was immediate and I did not even have to refresh. However, while I was notified of the post from step 2 (makes sense as I was mentioned), further posts sent after step 4 did not cause any notification, or appear on my write.as profile as seen from my Mastodon account. Enabling or disabling notifications (right next to the Unfollow button) changes nothing. |
Right, Mastodon switches it to "Unfollow" immediately no matter what, so you need to refresh the page to make sure it worked. When you refresh, does it still say "Unfollow"? |
Nope -- Cancel follow request This seems to contradict the hypothesis that if an instance receives a connection from write.as then it will unblock connections to write.as; I can confirm that on step 2, my mastodon.art account was indeed notified that it had been mentioned in a write.as blog post. |
Same behaviour of @aaribaud even for me: @AAMfP@fosstodon.org and https://write.as/marco-bresciani/ |
@amwelles @aaribaud @marcoXbresciani, can you please try following your account again? I think I got to the bottom of this issue, which seems to only be related to our hosting environment on Write.as. I've since patched the issue, and am able to follow your accounts now. |
Hey, seems it works! I unfollowed the write.as account, deleted previous blogs on write.as, published a new blog post mentioning my Mastodon.art account, followed my write.as account from my Mastodon.art account, refreshed... And this time I don't get a "Cancel follow request", I get a proper "Unfollow". |
Yessss it works, on my machine! 😁
…________________________________
From: Albert ARIBAUD ***@***.***>
Sent: Wednesday, March 24, 2021 6:34:01 PM
To: writeas/writefreely ***@***.***>
Cc: Marco Bresciani ***@***.***>; Mention ***@***.***>
Subject: Re: [writeas/writefreely] Fix following from Mastodon with Authorized Fetch enabled (#439)
Hey, seems it works! I unfollowed the write.as account, deleted previous blogs on write.as, published a new blog post mentioning my Mastodon.art account, followed my write.as account from my Mastodon.art account, refreshed... And this time I don't get a "Cancel follow request", I get a proper "Unfollow".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#439 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALOLH42XMVVWO7LC6RSA63DTFIPATANCNFSM4YZXRKAA>.
|
Confirmed working for me as well! Thanks for all your work. 😊 |
Great to hear! Thanks for testing this, everyone. Will get this merged. |
This fixes federation with Mastodon instances that have Authorized Fetch turned on by signing the GET request to fetch the actor when a blog is first followed.
Closes T820