New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go.mod/go.sum #58
Conversation
This fixes build issues with: * go-bindata, which attempted a go get ... * pinning ikeikeikeike/go-sitemap-generator to 1.0.1 instead of master * replace all go-get with go build -o tmpbin/
Currently in the Arch package I am having to manually override the version of some dependencies, which is not ideal. Packaging is another area where this would help a lot. I am happy to contribute or help make this possible in any way that I can if there is anything blocking this from being merged. Thanks! P.S. the Travis failure can be fixed by using go get instead of |
@sheenobu Thanks for submitting this! By the way, your go-webfinger library was a big help for this project 🙂 If you don't mind splitting this into two PRs and making the Travis config change @SamWhited mentioned, that'll help a lot. Lastly, just need a quick signature on the CLA and then I'll get everything merged. |
No worries! Should we bump travis conf to 1.11? |
Yep, that'll work! |
Gentle ping; @sheenobu if you're not available to wrap this up, I'd be happy to rebase and get everything working. Let me know. |
please do! |
We now support Go modules, and I've used the Makefile as a starting place for a new |
This could probably be separated out into two separate diffs: 1. go.mod/go.sum and 2. makefile updates. but current master and 0.7.0 is broken with go modules due to go-bindata go get failing (since there is no GOPATH). Feel free to edit/use as needed.
This fixes build issues with: