Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new commentsEnabled property #89

Merged
merged 1 commit into from Apr 7, 2019
Merged

Support new commentsEnabled property #89

merged 1 commit into from Apr 7, 2019

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Apr 4, 2019

This is a field previously supported by PeerTube, and just recently added on PixelFed, that should inform other ActivityPub services whether or not comments / replies are enabled on any given post.

WriteFreely doesn't support comments today, so this will always be false. When we support them in the future, this value will reflect the author's choice to accept replies or not.

This is a field previously supported by PeerTube, and just recently
added on PixelFed, that should inform other ActivityPub services whether
or not comments are enabled on any given post. WriteFreely doesn't
support comments today, so this will always be false.
@thebaer thebaer added this to the 1.0 milestone Apr 4, 2019
@thebaer thebaer changed the title Support new commentsEnabled property Support new commentsEnabled property Apr 4, 2019
@thebaer
Copy link
Member Author

thebaer commented Apr 6, 2019

This is most useful when microblogging platforms respect this property, so this PR is waiting on a consensus from maintainers of those projects. So far, it looks like Pleroma won't support it:

asking software to voluntarily turn off the reply button is not a real solution.

And I'm not sure what Mastodon maintainers think yet.

@thebaer
Copy link
Member Author

thebaer commented Apr 7, 2019

Not sure we're going to get buy-in from the Mastodon team either, so I'm going to go ahead and merge.

@thebaer thebaer merged commit 24c56af into master Apr 7, 2019
@thebaer thebaer deleted the comments-enabled branch April 7, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant