Fix the build in Docker after enabling go modules #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling go modules requires that GO111MODULE is set, so we set it as an environment variable in the Dockerfile. Also, go-bindata is meant to be installed globally, so we force the install before enabling Go modules. Also, we update Go to 1.12 to fix a couple module builds.
|
Awesome, thank you! This looks good to me. On a related note, would you be interested in helping write the basic documentation for upgrading WF when using Docker (writefreely/documentation#2)? We could use some help in that area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #93 in the context of a Docker build.
Enabling go modules requires that GO111MODULE is set, so
we set it as an environment variable in the Dockerfile.
Also, go-bindata is meant to be installed globally, so we
force the install before enabling Go modules. Also, we update
Go to 1.12 to fix a couple module builds.